Disallow invalid values #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They would otherwise throw an exception which crashes Godot. Some parameters clamp, while others return with an error.
|
Thank you for your help with that. Not sure about @Dudejoe870's status ATM, but busy is probably a good guess. I'll try to build your changes to test at least. |
|
LGTM, the workflows are running right now to make sure everything builds properly (it probably does judging from the code, but just making sure) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid values would throw an exception which crashes Godot.
Each of the minimum and maximum values are retrieved from the documentation.
Some parameters clamp, while others return with an error.
I decided for each based on what makes sense.
Things like volume or pitch are clamped, while out of bounds indices are errors.